[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807625: Include output from /proc/device-tree/model in installation report



* Ian Campbell <ijc@hellion.org.uk> [2015-12-11 11:45]:
> > Sorry for being as unclear as usual. I meant: instead of special-casing
> > /proc/device-tree/model in "addfile" (to make sure we have proper line
> > endings), we could use readlink there and special-case based on whether the
> > ultimate location is below /sys/firmware/devicetree. But docs suggest that
> > might break in the future.
> 
> Could addfile somehow detect the lack of a \n at the end of any file and add it?
> 
> Someone recently taught me that instead of "cat file" you can use "grep ''
> foo" which adds the \n if needed, not sure if installation-report runs in a
> suitable context with a grep which does so?

I've now committed my original patch (since it's better than nothing).
If someone has an elegant way to add the missing newline, please
commit a follow-on patch.

-- 
Martin Michlmayr
http://www.cyrius.com/


Reply to: