[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807625: Include output from /proc/device-tree/model in installation report



On Fri, 2015-12-11 at 11:43 +0100, Cyril Brulebois wrote:
> Martin Michlmayr <tbm@cyrius.com> (2015-12-10):
> > * Cyril Brulebois <kibi@debian.org> [2015-12-11 04:44]:
> > > A cursory look suggests this file is made available through:
> > > > drivers/of/base.c:		proc_symlink("device-tree", NULL,
> > > > "/sys/firmware/devicetree/base");
> > 
> > Yopu're right.  It's also available via
> > /sys/firmware/devicetree/base/model but I'm not sure if that's
> > preferred.
> 
> Sorry for being as unclear as usual. I meant: instead of special-casing
> /proc/device-tree/model in "addfile" (to make sure we have proper line
> endings), we could use readlink there and special-case based on whether the
> ultimate location is below /sys/firmware/devicetree. But docs suggest that
> might break in the future.

Could addfile somehow detect the lack of a \n at the end of any file and add it?

Someone recently taught me that instead of "cat file" you can use "grep ''
foo" which adds the \n if needed, not sure if installation-report runs in a
suitable context with a grep which does so?

Ian.


Reply to: