Martin Michlmayr <tbm@cyrius.com> (2015-12-10):
> * Martin Michlmayr <tbm@cyrius.com> [2015-12-10 17:12]:
> > On ARM devices using Device Tree, /proc/cpuinfo doesn't list the actual
> > hardware device. This information can now be found in
> > /proc/device-tree/model. I think it makes sense to include that file
> > in the installation report.
(You deleted that part but yeah, that looks fine to commit.)
> One problem is that /proc/device-tree/model has a wierd line ending,
> so we end up with:
>
> /proc/device-tree/model: QNAP TS219 family^@/proc/ioports: 00001000-000fffff : PCI I/O
>
> in the report, but I think we can live with that.
Sure.
A cursory look suggests this file is made available through:
| drivers/of/base.c: proc_symlink("device-tree", NULL, "/sys/firmware/devicetree/base");
I first thought we might readlink the parameter passed to addfile and
add newlines (in case all files below /sys/firwmare/devicetree/base
have the same symptom and we want to avoid missing newlines for more
than just /model), but Documentation/ABI/testing/sysfs-firmware-ofw
suggests the destination of the symlink is not guaranteed to be stable
anyway…
Mraw,
KiBi.
Attachment:
signature.asc
Description: Digital signature