[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#765976: aiming for 8.2: tzsetup: please don't offer time zone selection for Germany



Holger Levsen <holger@layer-acht.org> writes:
...
> And that in spring 2014 I pointed this mistake out before it was in sid and 
> then it was still uploaded - as "Büsingen" is obviously the correct german 
> spelling of it(!)... since then, I kinda gave up and just whined on irc. Then 
> you asked me to file this bug, I did, nothing happened, so I thought I'd ping 
> this bug…

This appears to be a misunderstanding.

Holger seems to be working on the assumption that the patch was not
applied, whereas when I look at the git log I see that Christian
committed that change on Oct 22 last year, and that the change was in the
changelog as version 1:0.60

I've not checked when that got into an installer, but I guess it did
quite a long time ago.  The version in the current installer is 1:0.66

Presumably (judging from the fact that Holger's still talking about it)
the patch didn't work for some reason.

OK, so I just tried it with the debian-8.1.0-amd64-netinst.iso image,
and Holger is certainly right (see screenshot attached).

I note that there is only Berlin listed if I run this on the console:

  # grep DE /usr/share/tzsetup/tzmap
  DE Europe/Berlin

Whereas there is mention of both in /var/lib/cdebconf/templates.dat in
tzsetup/country/DE in the Choices: and Choices-C fields.  I guess that's
the cause of this bug.

In tzsetup there is a line:

  zone=$(grep "^$CC" /usr/share/tzsetup/tzmap | cut -d ' ' -f 2)

which I suppose we were expecting to do the trick, but that's in an if's
else branch, so I guess we're actually using the then branch instead.

tzsetup has not been touched since 2009, so it's not been introduced
recently there.

Did anyone actually test that the patch did what we had hoped after
Christian's commit?

Cheers, Phil.

Attachment: signature.asc
Description: PGP signature

Attachment: Screenshot_d-i_2015-08-10_16:54:19.png
Description: zombie =?utf-8?Q?B=C3=BCsingen?= question

-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY

Reply to: