[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#778617: grub-install often breaks in UEFI mode



On Tue, Feb 17, 2015 at 09:32:56AM -0500, Phillip Susi wrote:
>Package: grub-installer
>Version: 1.110
>
>I'm forwarding this patch from Ubuntu:
>
>https://launchpad.net/bugs/1303790
>
>On EFI, the boot disk argument given to grub-install is a dummy and is
>often the wrong disk or a non existent disk.  Grub is still installed to
>the correct place since it goes through the filesystem to /boot/EFI, but
>the function make_active_partition tries to look at the partition table
>on the dummy disk and throws an error.  Hence, I wrote the attached
>patch to disable the function on EFI.

Hi Phillip,

The logic looks ok, I guess, but I'd check more explicitly for
grub-efi-* instead of !grub-pc. There's several other architectures
that may use grub, and I'm not sure if/how they may need special
handling for active partitions...

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
  Armed with "Valor": "Centurion" represents quality of Discipline,
  Honor, Integrity and Loyalty. Now you don't have to be a Caesar to
  concord the digital world while feeling safe and proud.


Reply to: