[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#778617: grub-install often breaks in UEFI mode



Package: grub-installer
Version: 1.110

I'm forwarding this patch from Ubuntu:

https://launchpad.net/bugs/1303790

On EFI, the boot disk argument given to grub-install is a dummy and is
often the wrong disk or a non existent disk.  Grub is still installed to
the correct place since it goes through the filesystem to /boot/EFI, but
the function make_active_partition tries to look at the partition table
on the dummy disk and throws an error.  Hence, I wrote the attached
patch to disable the function on EFI.

------------------------------------------------------------
revno: 121
committer: Phillip Susi <psusi@ubuntu.com>
branch nick: grub-installer
timestamp: Tue 2015-02-17 09:15:44 -0500
message:
  Don't try to mark a partition as active, except on grub-pc.
  This was causing failures for grub-efi (LP: #1303790).
diff:
=== modified file 'debian/changelog'
--- debian/changelog	2014-10-06 18:29:15 +0000
+++ debian/changelog	2015-02-17 14:15:44 +0000
@@ -1,3 +1,10 @@
+grub-installer (1.78ubuntu24) vivid; urgency=medium
+
+  * Don't try to mark a partition as active, except on grub-pc.
+    This was causing failures for grub-efi (LP: #1303790).
+
+ -- Phillip Susi <psusi@ubuntu.com>  Tue, 27 Jan 2015 15:51:09 -0500
+
 grub-installer (1.78ubuntu23) utopic; urgency=medium
 
   * On ppc64el, wipe the PReP partition before installing grub-ieee1275,

=== modified file 'grub-installer'
--- grub-installer	2014-10-06 18:29:15 +0000
+++ grub-installer	2015-02-17 14:15:44 +0000
@@ -1006,6 +1006,12 @@
 }
 
 make_active_partition () {
+	if [ "$grub_package" != "grub-pc" ]; then
+	# only do this for grub-pc since on EFI $bootdev is a dummy argument
+	# and looking for a partition table on the wrong or non existing disk
+	# crashes the installer LP:#1303790
+		return
+	fi
 	bootdisk=
 	bootpart=
 	case $bootdev in

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: