[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#725714: Partial fix using hw-setup for the missing firmware problem in d-i?



On Wed, 2014-10-15 at 22:39 +0200, Petter Reinholdtsen wrote:
> [Ben Hutchings]
> > Again, this is not a workaround, this is the only fix there will be for
> > that bug.  The only thing that may change in the kernel to make this
> > easier is that it will do structured logging so in theory you don't need
> > to use grep, cut, etc.  In practice, as this is all shell scripts, you
> > will probably have to do similar grepping to read the structured log
> > information.
> 
> I reworded the comment. :)
> 
> > dmesg | sed -rn 's/^(\[[^]]*\] )?([^ ]+) [^ ]+: firmware: failed to load ([^ ]+) .*/\2 \3/p' > $fwlist
> > 
> > This avoids using magic numbers; also we don't have to assume that log
> > timestamps are enabled.
> 
> Good idea.  Included in the patch.
> 
> > Keep the 'in'.
> 
> Ah, fixed.
> 
> I've tested the patch just now, and it seem to be working as it
> should, so I committed it into the hw-detect git repository.

Thanks; glad to have this finally fixed. :-)

Ben.

-- 
Ben Hutchings
Horngren's Observation:
                   Among economists, the real world is often a special case.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: