Bug#683329: flash-kernel: Toshiba AC100 support broken
On Sat, 2014-01-11 at 13:20 +0100, Vincent Zweije wrote:
> The proposed code just looks for a relatively distinctive pattern in
> the output. Empty output will certainly not match this pattern. I
> think adding an exit status check only serves to obscure what's
> actually going on.
Actually I disagree, far from obscuring what is going on the use of
error exist status is idiomatic in Unix shell. Given you analysis of the
various error conditions (thank you) I think I will go with:
|| if ! abootimg="$(LC_ALL=C abootimg -i "$p" 2>/dev/null)"; then
|| continue
|| fi
Ian.
Reply to: