[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683329: flash-kernel: Toshiba AC100 support broken



I've just come across this old bug report and I'm wondering about the
proposed patch. Is it correct to continue on through the body of the
loop when that abootimg -i call has failed?

I would expect that either there would be a continue or a -z check.
Perhaps (untested):
	if ! abootimg="$(LC_ALL=C abootimg -i "$p" 2>/dev/null)"; then
		continue
	fi
?

Or perhaps:
	abootimg="$(LC_ALL=C abootimg -i "$p" 2>/dev/null || true)"
	if [ -z "$abootimg" ]; then
		continue
	fi
Or:
	abootimg="$(LC_ALL=C abootimg -i "$p" 2>/dev/null || echo "none")"
	if [ "$abootimg" = "none" ]; then
		continue
	fi

I'm not familiar with abootimg so I don't know what the expect failure
modes actually look like.

Ian.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: