Bug#706659: [hw-detect] Claims some hardware (Realtek) needs merely ideal firmware to operate

[Filipus Klutiero <chealer@gmail.com>]

Package: hw-detect
Version: 1.92
Severity: normal

check-missing-firmware.sh asks administrators whether they want to install non-free firmware which would expand the capabilities of their computer:

ask_load_firmware () {
    if [ "$first_try" ]; then
        first_try=""
        return 0
    fi

    if [ "$NONINTERACTIVE" ]; then
        if [ ! "$first_ask" ]; then
            return 1
        else
            first_ask=""
            return 0
        fi
    fi

    db_subst hw-detect/load_firmware FILES "$files"
    if ! db_input high hw-detect/load_firmware; then
        if [ ! "$first_ask" ]; then
            exit 1;
        else
            first_ask=""
        fi
    fi
    if ! db_go; then
        exit 10 # back up
    fi
    db_get hw-detect/load_firmware
    if [ "$RET" = true ]; then
        return 0
    else
        echo "$files" | tr ' ' '\n' >> $DENIED
        return 1
    fi
}

Typically, a device won't operate without the non-free firmware designed for it. The prompt therefore reads:

Template: hw-detect/load_firmware
Type: boolean
Default: true
# :sl2:
_Description: Load missing firmware from removable media?
 Some of your hardware needs non-free firmware files to operate. The
 firmware can be loaded from removable media, such as a USB stick or
 floppy.
 .
 The missing firmware files are: ${FILES}
 .
 If you have such media available now, insert it, and continue.

But it is not always the case that a device needs a firmware designed for it to operate. Some devices are simply enhanced by firmware. This is particularly true for my Ethernet card, a Realtek 8111F. While firmware-realtek does provide firmware for it, that firmware merely patches a bug in the default firmware. This bug apparently only happens in specific contexts. I have been using a PC with that card without the firmware for more than 2 weeks without any apparent network issue. Therefore, the prompt is misleading and may cause the user to install unneeded software or change hardware without a strong reason.

Ideally, d-i would explain the advantages of each firmware. The simplest solution would be to say the firmware enables or helps a device. A middle solution could be to tag firmware as necessary or optional.

The opposite case (d-i not recommending firmware when it should) also exists (#649851). But fixing these cases will expose this bug even more. Radeon cards are good examples of devices which are improved by firmware without being unusable without.

--- System information. ---
Architecture: i386
Kernel: Linux 3.8-trunk-amd64

Debian Release: 7.0
990 testing security.debian.org
990 testing debian.mirror.iweb.ca
500 unstable debian.mirror.iweb.ca
1 experimental debian.mirror.iweb.ca

--- Package information. ---
Package's Depends field is empty.

Package's Recommends field is empty.

Package's Suggests field is empty.