[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: UUID in fstab for device mapper devices?

On Sat, Aug 08, 2009 at 04:03:38PM +0200, Max Vozeler wrote:
> If there is rough concensus about this, I would go ahead and make
> the change to use /dev/mapper in partman-target.

OK, it seem there is consensus. (last chance to protest! :) )

I have committed the attached change to partman-target which 
makes d-i use /dev/mapper in the generated fstab.

Thanks for the advice everyone.

Author: xam
Date: Thu Aug 13 00:15:38 2009
New Revision: 60137

Use /dev/mapper/ paths instead of UUID to refer to device 
mapper devices in /etc/fstab.

Those names are meant to be stable and result in simpler
and clearer fstab entries.

Discussion leading to this change:


Modified: trunk/packages/partman/partman-target/debian/changelog
--- trunk/packages/partman/partman-target/debian/changelog	Wed Aug 12 23:46:18 2009	(r60136)
+++ trunk/packages/partman/partman-target/debian/changelog	Thu Aug 13 00:15:38 2009	(r60137)
@@ -1,5 +1,7 @@
 partman-target (63) UNRELEASED; urgency=low
+  * Use /dev/mapper/ paths instead of UUID to refer to device 
+    mapper devices in /etc/fstab.
   * Use LABEL rather than UUID for entries in /etc/fstab if the 
     label was explicitly configured by the user.

Modified: trunk/packages/partman/partman-target/finish.d/fstab_hd_entries
--- trunk/packages/partman/partman-target/finish.d/fstab_hd_entries	Wed Aug 12 23:46:18 2009	(r60136)
+++ trunk/packages/partman/partman-target/finish.d/fstab_hd_entries	Thu Aug 13 00:15:38 2009	(r60137)
@@ -31,7 +31,7 @@
 	sort |
 	while read mp fs type options dump pass; do
 		case "$fs" in
-		    (/dev/disk/*|/dev/fd[0-9]*|/dev/mapper/*_crypt)
+		    (/dev/disk/*|/dev/fd[0-9]*|/dev/mapper/*)
 			addfstab "$(mapdevfs $fs)" "${mp}" "$type" "$options" "$dump" "$pass"

Reply to: