[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#525209: Layout messed up in daily images



On Thu, Apr 23, 2009 at 12:32:28AM +0200, elendil@planet.nl wrote:
> 
> This is almost certainly a result of the cdebconf changes committed by 
> Nicolas François (CCed).

Yes.

It looks like I assumed there were no Go Back button in those case.

Here is a patch.

I tested it just a little bit. It seems to solve the issue without
re-introducing the previous issue.


If somebody knows how to test it in a daily image, please do (I don't know
how to do this).


If urgent, somebody can commit it and upload.
Otherwise, I will try to test it more this week-end.

Best Regards,
-- 
Nekral
Index: src/modules/frontend/newt/newt.c
===================================================================
--- src/modules/frontend/newt/newt.c	(révision 58334)
+++ src/modules/frontend/newt/newt.c	(copie de travail)
@@ -777,13 +777,15 @@
         t_height = newtTextboxGetNumLines(textbox);
         newtTextboxSetHeight(textbox, t_height);
         newtFormAddComponent(form, textbox);
-        b_height = 0; // A <Go Back> button is not necessary
         select_list_top = 1+t_height+1;
     } else {
         t_height = 0;
-        b_height = 1;
         select_list_top = 1; // No description. Only insert a blank line.
     }
+    if (obj->methods.can_go_back(obj, q))
+        b_height = 1;
+    else
+        b_height = 0;
     free(full_description);
     win_height  = t_height + sel_height + b_height;
     //    3 == First blank line + blanks before and after select

Reply to: