[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] RAID10 and RAID6



Quoting Frans Pop (elendil@planet.nl):

> Index: mdcfg/debian/mdcfg-utils.templates
> ===================================================================
> --- mdcfg/debian/mdcfg-utils.templates	(revision 54408)
> +++ mdcfg/debian/mdcfg-utils.templates	(working copy)
> @@ -107,6 +107,80 @@
> [...]
> 
> +Template: mdcfg/raid10sparecount
> +Type: string
> +# :sl3:
> +_Description: Number of spare devices for the RAID10 array:
> 
> +Template: mdcfg/raid6sparecount
> +Type: string
> +# :sl3:
> +_Description: Number of spare devices for the RAID6 array:
> 
> #### (second one taken from lower down in the patch)
> #### I wonder if we should consolidate such strings that only have "RAIDx"
> #### different between them. However, that could/should be a separate change.
> 
> #### Christian: what do you think? Would RAIDx need to be translatable if
> #### we did that?

Well, so far I don't see any translator using anything but "RAIDx" to
translate "RAIDx". 

The question is indeed: is there a chance that "RAID6 array"
translates differently than "RAID10 array" in some languages? One can
never tell but I think that the probability is very low.

So, I'd actually vote to consolidate the strings if that's possible.


> 
> [...]
> 
> +Template: mdcfg/raid10layout
> +Type: string
> +# :sl3:
> +_Description: Layout of the RAID10 multidisk device:
> + The layout must be n, o, or f followed by a number.
> + .
> + The number is the number of copies of each chunk.
> + It has to be equal to or smaller than the number of active devices.
> + .
> + The letter is the arrangement of the copies.
> +  n - near copies: Multiple copies of one data block are at similar offsets in different devices.
> +  f - far copies: Multiple copies have very different offsets
> +  o - offset copies: Rather than the chunks being duplicated within a stripe, whole stripes are duplicated but are rotated by one device so duplicate blocks are on different devices.
> 
> #### Don't the lines above need explicit \n at the end?


They do, yes:

 The letter is the arrangement of the copies:
   n - near copies  : Multiple copies of one data block are at similar
                      offsets in different devices.
   f - far copies   : Multiple copies have very different offsets
   o - offset copies: Rather than the chunks being duplicated within a
                      stripe, whole stripes are duplicated but are rotated
                      by one device so duplicate blocks are on
                      different devices.


> 
> + .
> + The default setting is n2.
> + .
> + NOTE: this setting cannot be changed later.


That template is too long. I'd suggest dropping the mention of default
(after all, it's already visible when the user first sees the
template) and the last sentence.

I would also suggest putting together the first two paragraphs, even
the first three:

_Description: Layout of the RAID10 multidisk device:
 The layout must be n, o, or f (arrangement of the copies) followed
 by a number (number of copies of each chunk). The number must be
 smaller or equal to the number of active devices.
 .
 Arrangements of the copies:
  n - near copies: Multiple copies of one data block are at similar offsets in different devices.
  f - far copies: Multiple copies have very different offsets
  o - offset copies: Rather than the chunks being duplicated within a stripe, whole stripes are duplicated but are rotated by one device so duplicate blocks are on different devices.


> 
> @@ -135,6 +209,26 @@
>   Please choose which partitions are active devices.
>   You must select exactly ${COUNT} partitions.
>  
> +Template: mdcfg/raid6devs
> +Type: multiselect
> +Choices: ${PARTITIONS}
> +# :sl3:
> +_Description: Active devices for the RAID6 multidisk device:
> + You have chosen to create an RAID6 array with ${COUNT} active devices.
> + .
> + Please choose which partitions are active devices.
> + You must select exactly ${COUNT} partitions.

Is it "an RAID6" or "a RAID6"? As "RAID" begins with a consonant, I'd
vote for "a RAID".


> +
> +Template: mdcfg/raid10devs
> +Type: multiselect
> +Choices: ${PARTITIONS}
> +# :sl3:
> +_Description: Active devices for the RAID10 multidisk device:
> + You have chosen to create an RAID10 array with ${COUNT} active devices.
> + .
> + Please choose which partitions are active devices.
> + You must select exactly ${COUNT} partitions.


Ditto

> 
> #### These would be candidates for consolidation as well.


Yep.


Attachment: signature.asc
Description: Digital signature


Reply to: