On Friday 18 July 2008, Ryan Niebur wrote: > I split the patch up like Jérémy said to. In the first patch the MISSING_DEVICES variable should be initialized to empty in the main code line, not inside some conditional statement based on the RAID level. That goes for _all_ variables used in the generic mdadm --create call. I see that the second patch has an "unset" at the end. If that is needed, then please use 'local' instead [1] to define the variables; the "unset" does not remove the need for proper initialization. Note that 'local' by itself does _not_ initialize a variable in busybox shell. Cheers, FJP [1] mdcfg is very much an "old" D-I component and is scheduled to be fully integrated into partman (as was previously done for lvmcfg); partman is much more structured and fairly consistently uses declaration of local variables in functions.
Attachment:
signature.asc
Description: This is a digitally signed message part.