Re: preliminary patch towards XEN virtual disk naming
Ian Campbell <ijc@hellion.org.uk> writes:
> On Sun, 2008-04-20 at 18:56 +0200, Frans Pop wrote:
>> On Tuesday 08 April 2008, Ian Campbell wrote:
>> > On Tue, 2008-04-08 at 20:35 +0200, Frans Pop wrote:
>> > > I would vote for starting the numbering at 1, not 0, as linking 1 to
>> > > xvda is most natural.
>> > >
>> > > One option would be to just
>> > > use "Virtual disk" in partman (without "Xen" before it). Then parted's
>> > > description would be a useful further specification of the type of
>> > > virtual disk.
>> >
>> > Both of those sound like reasonable ideas to me.
>>
>> Ian or Ferenc: could either of you please submit a final patch based on the
>> discussions so far (or point me to the one that should be used)?
>
> Lets go with this one. It counts the disks from 1 (==xvda) and simply
> calls it a "Virtual Disk" as suggested this has the advantage of not
> wrapping in various dialogs too (like the formatting partition one if I
> remember correctly).
>
> Disk selection dialog now looks like:
> ┌────────────────────────┤ [!!] Partition disks ├─────────────────────────┐
> │ │
> │ Note that all data on the disk you select will be erased, but not │
> │ before you have confirmed that you really want to make the changes. │
> │ │
> │ Select disk to partition: │
> │ │
> │ Virtual Disk 1 (xvda) - 8.6 GB Unknown │
> │ │
> │ <Go Back> │
> │ │
> └─────────────────────────────────────────────────────────────────────────┘
It looks great. I'd say to wait for another ack by Frans and Christian
and go ahead.
> I've left any parted enhancements out for now, as you say they would be
> a useful further specification in the future.
Please post the proposed patch so I can take a look at it.
> Perhaps it would be useful to name the templates
> partman/text/virtual_disk_{,partition} or similar to enable sharing
> under other virtualisation platforms?
I think so... let's wait people comments about it too.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
Reply to: