[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch to tidy up wget use, and add return=4 when 404's are seen

Some last minor nitpicks.

Otherwise OK from me to commit, provided it has been tested at least in a 
full regular netboot install and a preseeded netboot install.
Please check the syslog for unexpected errors during/after the tests.

On Friday 14 March 2008, Philip Hands wrote:
> So, here we go again:
>   http://hands.com/~phil/d-i/fetch-url-3.diff

+++ b/packages/debian-installer-utils/README
+The options modify it's behaviour thus (for those methods where they
+make sense -- ftp & http currently -- otherwise they're ignored):

s/it's/its/   (didn't we have already have one like that? ;-)

+debian-installer-utils (1.56) UNRELEASED; urgency=low

Note that other changes have been committed in the meantime, so you'll have 
to update and fix the resulting conflict in the changelog before 

+++ b/packages/preseed/README.preseed_fetch
+fetch-url from di-utils actually does the heavy lifting, with
+preseed_fetch only adding the relative path functionality

Period missing at end of sentence.

>   http://hands.com/~phil/d-i/wget404-3.diff

+++ b/packages/debian-installer-utils/debian/changelog
+  * take inspiration from net-retriever about wget -c

I don't understand this changelog entry. How did we take inspiration? Does 
this really belong with the second patch or rather with the first. Didn't 
we rather take the inspiration from cdebconf?


Attachment: signature.asc
Description: This is a digitally signed message part.

Reply to: