Bug#406911: user-setup: last set of bugfixes stops passwd/make-user=false from working

[Luke Kenneth Casson Leighton <lkcl@lkcl.net>]

On Mon, Jan 15, 2007 at 08:55:02PM -0500, Joey Hess wrote:
> Luke Kenneth Casson Leighton wrote:
> > frans,
> > 
> > why is functions.sh returning '1' if the file $ROOT/etc/passwd exists,
> > in both the is_system_user and root_password functions?
> > 
> > surely this should be 0 in both instances?
> 
> Er, it's not:
> 
>         if ! [ -e $ROOT/etc/passwd ]; then
>                 return 1
>         fi
> 
> This returns 1 if it _doesn't_ exist.
> 
> > especially look at like 47 of user-setup-ask - it says if [ !  root_password]
> 
>                 elif ! root_password; then
> 
> So if there's no $ROOT/etc/password, root_password will return false,
> and this confitional will succeed, and it will go on to check for a
> preseeded root password. Seems like the right thing to do..
 
 yes - phil, who also understands shell scripts (which i don't even
 pretend to understand) explained it to me.

 sorry for taking up your time with this one, guys.

 l.



-- 
--
lkcl.net - mad free software computer person, visionary and poet.
--