[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#395259: nobootloader: [powerpc/pegasos] bad sed invocation breaks devfs style paths (division by zero)

On Thu, Oct 26, 2006 at 03:25:33AM +0200, Frans Pop wrote:
> On Wednesday 25 October 2006 23:12, Sven Luther wrote:
> > It seems that nobootloader uses still devfs paths for some reason. The
> > following line :
> That is not so strange as that line is using the exact same variable 
> $bootfs_devfs as its base that the old code did...
> Should it be using something different instead? What is the value of 
> $bootfs_disk_syspath and $bootfs_disk if you run the code with 'set -x'?
> For now I've added a comment that that should probably be changed at some 
> point.
> (To be very honest, I don't see the point of the code added in 1.10 at all 
> as the devfs path is still used as the base for the whole piece of code; 
> I guess it is in preparation of a further future transition.)

Don't be misled by the variable name. It's called $bootfs_devfs because
it's the path before calling mapdevfs; if you aren't using devfs paths
then $bootfs_devfs and $bootfs are identical. What $bootfs_devfs really
means is "the version of this path that can be used within d-i".

I've just committed an IMHO better fix which will work for both devfs
and non-devfs paths. Sven, thanks for the report.

Colin Watson                                       [cjwatson@debian.org]

Reply to: