[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [G-I] testresults using new gtk2-engines udeb

Frans Pop wrote:
I have just tested the image created yesterday by Davide. The installer
looks very nice, it solves the bug where the selected item in multiselect
lists is not displayed and I've seen no regressions.

There is one minor issue. VT1 gets flooded with two messages:
* Repeated a lot:
  (debconf: 9999): Gdk-DirectFB-WARNING **: gdk_directfb_gc_set_dashes not implemented
* Repeated a lot while progress bar is running:
  Gdk_DirectFB-Message: filled polygons with n > 3 are not yet supported, drawing outlines

Seems like the engine uses some "advanced" features that are not supported
by gdk-directfb, though it does seem to cleanly fall back to alternatives.
I'd like to prevent the flooding of VT1 though; would it be possible to
suppress these warnings?

That's because filled polygon with more than 3 edges drawing is not currently supported: a patch for this exists, but wasn't committed yet AFAIK [1]. To prevent VT1 pollution, such warnings could be simply silenced (see attached patch).

I have one question: how will implementing this clearlooks engine affect
implementing the bladr and "dark" theme? I'd like to avoid implementing
several different themes/engines for Etch and instead stick to only:
- one default theme
- the dark theme (or rather one theme for visually impaired people)

AFAIK, Bladr and the dark theme are no longer needed / applicable, as they use the libpixmap engine, not clearlooks, and should not be packaged in the g-i. IIRC, loic has also packages the h(igh)c(ontrast)engine engine, which should be ok to implement accessibility. We may need tweak something in rootskel-gtk to allow GTK theme choose at boot time.



[1] http://mail.directfb.org/pipermail/directfb-dev/2006-October/002387.html
Index: gdkdrawable-directfb.c
RCS file: /cvs/gnome/gtk+/gdk/directfb/gdkdrawable-directfb.c,v
retrieving revision 1.6
diff -u -r1.6 gdkdrawable-directfb.c
--- gdkdrawable-directfb.c      11 Aug 2006 05:44:46 -0000      1.6
+++ gdkdrawable-directfb.c      13 Oct 2006 13:44:28 -0000
@@ -526,9 +526,9 @@

-                else
-                        g_message ("filled polygons with n > 3 are not yet supported, "
-                     "drawing outlines");
+//                else
+//                        g_message ("filled polygons with n > 3 are not yet supported, "
+//                     "drawing outlines");

   if (points[0].x != points[npoints-1].x ||
Index: gdkgc-directfb.c
RCS file: /cvs/gnome/gtk+/gdk/directfb/gdkgc-directfb.c,v
retrieving revision 1.1
diff -u -r1.1 gdkgc-directfb.c
--- gdkgc-directfb.c    5 Feb 2006 04:04:28 -0000       1.1
+++ gdkgc-directfb.c    13 Oct 2006 13:44:28 -0000
@@ -334,7 +334,7 @@
                             gint8  dash_list[],
                             gint   n)
-  g_warning ("gdk_directfb_gc_set_dashes not implemented");
+//  g_warning ("gdk_directfb_gc_set_dashes not implemented");

 static void

Reply to: