[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#281538: languagechooser: [s390] Invalid setup of localization

On Thursday 18 November 2004 22:07, Matt Kraai wrote:
> On Wed, Nov 17, 2004 at 07:11:42PM +0100, Frans Pop wrote:
> This will overwrite instead of append to
> /target/root/dbootstrap_settings.
> Likewise for /target/etc/environment.

I know. That was a conscious choice as I think this step in the 
installation is the first step responsible for setting up this file.
Both files are not claimed by a regular package if I check with dpkg -S 
and packages.d.o.

With the assumption that this step is responsible for setting them up, the 
old situation of adding to the file seemed unneeded and possibly broken 
to me (as double entries could be created by just assuming the entries 
are not yet present; harmless I know, but broken anyway).

For dbootstrap_settings at least, I intend to check with the scolinux 
people (as in theory there could be a base file installed in the 
base-installation step from a custom package).
For /etc/environment I am certain that this is the first time the file is 
set up and so that creating it is correct.

A cleaner and probably better alternative could be to create a function or 
utility script (e.g. in d-i-utils) that creates the file if it does not 
exist or else first checks if a variable is already set in the file and 
either replaces the current line or removes the current line and appends 
a new line with the new setting.
(Unless someone knows of an existing command that will do this.)

I think I will create a new patch that includes this system.

Reply to: