Hi,
On Fri, Jul 09, 2004 at 11:13:46PM +0200, Per Olofsson wrote:
> Hello,
>
> I have created a new version of pcmcia-cs now which defaults to not
> bringing up new interfaces with ifup.
Thanks ... but
> However, I am not currently on
> an ethernet connection, so I'm unable to test it. I'm therefore asking
> for your help with this. The package is available at [1]. You'll have
> to build it yourself because of my limited bandwith, but it hasn't too
> many dependencies. You'll have purge the old version or remove
> /etc/default/pcmcia to get the new default.
Hmmm... Are you going to document this new feature in README.Debian?
A bit awkward if one upgrades system and reads some other documentation
on hotplug later documenting new setup.
Can not we take care better in postinst?
Minimal change option is as follows:
--- pcmcia-cs.postinst.old 2004-07-10 14:33:27.000000000 +0200
+++ pcmcia-cs.postinst 2004-07-10 15:10:02.000000000 +0200
@@ -25,6 +25,15 @@
# network interfaces. They should be brought up by hotplug instead.
REFRAIN_FROM_IFUP=yes
EOF
+ else
+ if ! grep -q '^REFRAIN_FROM_IFUP=' $CFG ; then
+ cat >>$CFG <<EOF
+# If REFRAIN_FROM_IFUP is set to yes, cardmgr will not bring up
+# network interfaces. They should be brought up by hotplug instead.
+# Since this is upgrade from an old system, it retains old behavior.
+REFRAIN_FROM_IFUP=no
+EOF
+ fi
fi
db_get pcmcia-cs/fix_pcic
if [ "$RET" = "true" ]; then
-----
Of course there may be more complicated solution reading HOTPLUG
configuration. Well, that is too complicated.
Maybe comments may be improved but I think you get my idea.
Just my 2 cents.
Osamu
Attachment:
signature.asc
Description: Digital signature