[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#215404: di_check_dir() missing



On Sun, 2003-11-02 at 08:34, Petter Reinholdtsen wrote:
> [Richard Hirst]
> > debug builds of kbd-chooser call di_check_dir() but versions of
> > libdebian-installer beyond 0.15 do not provide it.
> 
> Checking d-i/doc/libdi-changes.txt, I do not find that function
> mentioned at all.  I'm not sure what happened to it, nor why it was
> removed.
> 
> Perhaps kbd-chooser should be changed instead of libd-i?  The function
> is used in quite a few places in kbd-chooser:
> 
>   at-kbd.c:     assert (di_check_dir ("/proc") == 1);
>   at-kbd.c:     if (di_check_dir ("/proc/bus/input") >= 0) {
>   usb-kbd.c:    if (di_check_dir ("/proc/bus/input") >= 0) { // 2.6 kernel
>   acorn-kbd.c:  assert (di_check_dir ("/proc") == 1);
>   acorn-kbd.c:  if (di_check_dir ("/proc/bus/input") >= 0) {
>   amiga-kbd.c:  assert (di_check_dir ("/proc") == 1);
>   amiga-kbd.c:  if (di_check_dir ("/proc/bus/input") >= 0) {
>   mac-kbd.c:    if (di_check_dir ("/proc/bus/input") >= 0) {
>   sparc-kbd.c:    assert (di_check_dir ("/proc") == 1);
>   sparc-kbd.c:    if (di_check_dir ("/proc/bus/input") >= 0) {
> 
Hmm,

its currently used in #ifdef KERNEL_2_6 code in kbd-chooser, so we
build ok. di_check_dir() has recently been removed, despite my
requests. I don't understand why: with reduced libs, it doesn't
save any space to remove it. 
Never mind, I'll re-implement its functionality in kbd-chooser

Regards,
Alastair.



Reply to: