[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

cdebconf: return codes overloaded



Hi,

In cdebconf, the error codes used are overloaded
(and present in commands.h).

#define CMDSTATUS_SUCCESS           0
#define CMDSTATUS_BADQUESTION       10
#define CMDSTATUS_BADPARAM          10
#define CMDSTATUS_SYNTAXERROR       20
#define CMDSTATUS_INPUTINVISIBLE    30
#define CMDSTATUS_BADVERSION        30
#define CMDSTATUS_GOBACK            30
#define CMDSTATUS_INTERNALERROR     100

Why not have a separate value for each? 
What would break if we changed these to different values, for
better tracking?

Secondly, can we move these definitions to be visible in
<cdebconf/debconfclient.h> ? It would tidy up the code
not to have to refer to numerals.

- Alastair McKinstry



Reply to: