On Wed, Mar 06, 2002 at 08:17:05PM +0100, Eduard Bloch wrote:
> (*) BFs can install additional packages when isntalling from CD or from
> net. There should still be one hook to disable wants_locale if we are
> isntalling from prepared basedebs.tar.
I'm not really happy with this. Adding random new features to boot-floppies
right now is a very very bad idea. Our goals right now are to make sure what
we've currently got works for doing installs on all architectures, not making
stuff more elegant, and whatever.
Adding new features adds bugs, which cause inordinate delays. They are
not worth it anymore. Not for _anything_.
> Index: utilities/dbootstrap/extract_base.c
> +#ifdef USE_LANGUAGE_CHOOSER
> + if(wants_locale) {
> + argv[1] = "--boot-floppies";
> + argv[2] = "--include=debconf,locales";
> + /* people needing special terminal emulation can still extend the above */
> + argv[2] = "--boot-floppies";
> + argv[3] = "--arch";
> + argv[4] = ARCHNAME;
> + argv[5] = "woody";
> + argv[6] = "/target";
> + argv[7] = source;
> + argv[8] = NULL;
> + }
> + else {
> +#endif
> + argv[1] = "--boot-floppies";
> + argv[2] = "--arch";
> + argv[3] = ARCHNAME;
> + argv[4] = "woody";
> + argv[5] = "/target";
> + argv[6] = source;
> + argv[7] = NULL;
> + }
That trailing '}', eg, doesn't have a corresponding '{' if
USE_LANGUAGE_CHOOSER is unset.
Do not do this.
Cheers,
aj
--
Anthony Towns <aj@humbug.org.au> <http://azure.humbug.org.au/~aj/>
We came. We Saw. We Conferenced. http://linux.conf.au/
``Debian: giving you the power to shoot yourself in each
toe individually.'' -- with kudos to Greg Lehey
Attachment:
pgpCIyrVkWvVX.pgp
Description: PGP signature