[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: "Choose debian archive" box confusing

Martin Schulze <joey@finlandia.Infodrom.North.DE> writes:

> I've fixed Bug#67082 and wonder if I may commit the code.  I've
> decided to really fix it and get back the old behaviour instead of
> just editing the message text (which would affect all translators to
> fix their text as well).
> What I've done technically:
>  . enterDirBox() and choose_dir() got one more parameter, telling them
>    to limit the display and searches to one directory, called prefix,
>    initialized with CM_MOUNTPOINT_DIR aka /instmnt.
>  . choose_dir() got some magic to map / to prefix and to traverse the
>    directory accordingly
>  . choose_archive_dir() got some magic as well to prefix the directory
>    with CM_MOUNTPOINT_DIR aka /instmnt but don't display it and don't
>    confuse the user with it.
>  . choose_archive_dir() defaults to "" instead of /instmnt as well
> I wonder if I shall commit the code or not.  Waiting for confirmation.

I think that would be fine.  Some have argued that it's better to have
more flexibility and allow people to go to whever they want (say if
they did the mount in tty2).  To address that, we should simply
mention this directory is relative to the /instmnt dir.  Bonus points
would be to allow the user to specify ../foo to get to the top-level
foo directory.

Commit away, I say, if you haven't already.

.....Adam Di Carlo....adam@onShore.com.....<URL:http://www.onShore.com/>

Reply to: