[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#36947: base.tgz not found - no error message



reopen 36947
thanks

I just installed the 2.1.8 sources, and had a look.  Well, I must say
I'm not quite at ease with this virtually undocumented code :(

To start with I had a look at main_menu(), extract_base() and
choose_medium(), and I found some things quite strange.  Especially,
the return status from extract_base() and others IS NOT CHECKED.
extract_base() returns 1 in the case of an error, but AFAICT this is
totally ignored by main_menu().

I strongly suspect that in the case where I encountered these problems
some underlying function produced an error, which may even have been
reported up to main_menu().

main_menu() should be able to report that an error occured - this
makes this bug important if not grave.  In order to have some function
report the error with a useful error message, I'd suggest that some
errno-like error codes be used throughout the code.

Regards,
-- 
Yann Dirson                         |    Why make M$-Bill richer & richer ?
           <ydirson@multimania.com> |   Support Debian GNU/Linux:
debian-email:   <dirson@debian.org> | Cheaper, more Powerful, more Stable !
http://www.multimania.com/ydirson/  | Check <http://www.debian.org/>


Reply to: