[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [GSoC] Prospective packages importer



On Mon, Aug 24, 2015 at 06:38:45PM +0530, Akshita Jha wrote:
> >
> > I will delete the imageio.git / keep python-imageio.git.
> >
> > That's also a good reminder to finish that work at some point.
> 
> udd=# select package, count(*) from blends_prospectivepackages group by
> package having count(*) > 1;
>      package     | count
> -----------------+-------
>  python-imageio  |     2
>  python3-imageio |     2
> (2 rows)

Yes, that's what I did. :-)
 
> 
> I have sent new patches that:
> 
> 1. add primary key constraint to blends_prospectivepackages making
> "package" as primary key
> 2. create table blends_unknown_packages (primary key - package)
> 3. create table package_remark (primary key - package)

OK.
 
> Also, as noted above python-imageio, python3-imageio are the only packages
> that violate the primary key constraint. If these packages are removed,
> then we'll not have any duplicates and because of the constraint there will
> be no duplicates in future.
> 
> So, should I modify the importer to again check for this constraint ? Or,
> will it suffice to remove these packages and add constraint primary key
> (package) to blends_prospectivepackages ?

Checking might not harm to create a proper error message since it can
happen again in the future.

Kind regards

     Andreas.

-- 
http://fam-tille.de


Reply to: