Re: [RFS] casacore-1.7.0 uploaded to mentors
Dear Ole,
Ole Streicher <olebole@debian.org> writes:
> heroxbd@gmail.com writes:
>> Thanks for reviewing the package. I have uploaded a new version to
>> mentors,
>
> The package is quite OK; just two points are IMO required for an upload
>
> * The tools package does not contain manpages, which are a "should" in
> the Debian policy (12.1). Since the binaries already have some help
> output, it should not be difficult to write manpages, or try out the
> "help2man" program.
done. It turns out to be non-trivial at all. The helps cannot be
parsed by help2man, and the manpages are created manually.
> * please change the distribution in debian/changelog from UNRELEASED to
> unstable
done
> What is not required, but should be considered is to replace the exit()
> functions in the library by abort() (and share this with
> upstream). Calling exit has the disadvantage that the program just ends
> in the middle of a library call, and this is difficult to debug. abort()
> at least gives the possibility to get a stack trace.
Agreed. On the wishlist.
> On a longer term, I would also recommend to create symbols files. They
> make it easier for other packages to find out which minimal version of
> casacore they actually need. However, I'd not put any urgency here.
Some investigation suggests that tracing C++ ABI and symbols is not a
good idea. shlibs is enough for such case.
http://www.eyrie.org/~eagle/journal/2012-02/001.html
> But the package looks fine for me! You have put a lot of good work into
> it!
Thanks, Ole. I have pushed the changes into git repo,
https://anonscm.debian.org/cgit/debian-astro/packages/casacore.git
and mentors,
http://mentors.debian.net/package/casacore
http://mentors.debian.net/debian/pool/main/c/casacore/casacore_1.7.0-1.dsc
Ready to upload?
Cheers,
Benda
Reply to: