1.3.34-4.1+etch1 apache-contrib-1.0.8a/mod_cgisock/mod_cgisock.c

[swivel@shells.gnugeneration.com]

Hello,

Listing from subject:

 74 #ifndef sockaddr_un
 75 struct sockaddr_un {
 76     unsigned short sun_family;
 77     char sun_path[UNIX_PATH_MAX];
 78     };
 79 #endif

The #ifndef/#endif preprocessor directives are useless.

If sockaddr_un struct is actually defined, only the compiler will know not
the preprocessor.

I found this because a patch I've created adds sys/un.h to the ap_config.h
includes because I'm working with UNIX domain sockets.  This results in
sockaddr_un struct being defined.  When trying to rebuild my apache packages
with my patch integrated, build fails here because of the redefinition of
sockaddr_un.  My patch doesn't touch anything under contrib.

Why not simply include sys/un.h in mod_cgisock.c?

Please reply to me directly as I'm not subscribed to your list... This
address was found in dpkg -p apache output.

Regards,
Vito Caputo