* James Bromberger (james@rcpt.to) wrote : > On Sat, Feb 16, 2002 at 04:56:49AM +0000, Matthew Wilcox wrote: > > #111216: This should get fixed. Probably quite straight forward -- > > make mod_bandwidth use a suitable directory underneath /var instead. > > /usr/share/doc/apache-common/README.mod_bandwidth sez: "no documentation > available". The web site for the modeule at http://www.cohprog.com/ > seems to not show me anything with mozille 0.9.8. Anyways, > sure, how about using /var/state/apache/mod-bandwidth? > Sounds good; patch attached. > > > #132062: Should be straightforward for a perl hacker > [ apacheconfig doesnt handle httpd.conf as a directory ] [code elided] > > Does this not deal with the case where $file is a directory already? Yes, and httpd.conf is one of the files that uses this code to be read with. This one would be fixed then ;-) > > > > #132472: Yeah, probably should just change the permissions. > > Any objections? > > Seems sane to me. Its broke now, if the report is correct. Go ahead. > +1 Cheers, -Thom --- mod_bandwidth.co.orig Sat Feb 16 20:27:04 2002 +++ mod_bandwidth.c Sat Feb 16 20:35:41 2002 @@ -340,8 +340,8 @@ #define MIN_BW_DEFAULT 256 /* Minimal bandwidth defaulted to 256Bps */ #define PACKET 1024 /* Sent packet of 1024 bytes */ -#define MASTER_DIR "/tmp/apachebw/master" -#define LINK_DIR "/tmp/apachebw/link" +#define MASTER_DIR "/var/state/apache/mod-bandwidth/master" +#define LINK_DIR "/var/state/apache/mod-bandwidth/link" #ifdef USE_MMAP_FILES #include <unistd.h>
Attachment:
pgpey5Cex5w6W.pgp
Description: PGP signature