Le 19.10.2005 22:40:27, Corey Hickey a écrit :
Jean-Luc Coulon (f5ibh) wrote:
>>>me) dont dont accept the -xvidencopts suboption which is used by
>>>acidrip, typically with something like:
>>> ".... -xvidencopts :bitrate=759:pass=2 ..."
>>>
>>
>>Yes, the ':' before bitrate is a syntax error. I don't know if
earlier
>>versions of mencoder were tolerant of that.
I don't know perl, but I can see what's going on.
Line 221 of AcidRip/acidrip.pm:
$menc{'video'} = "-ovc xvid -xvidencopts
$::settings->{'xvid_options'}:bitrate=$::settings->{'video
_bitrate'}";
xvid_options is empty, leaving only the ':'. Mencoder accepts a
trailing
':', so you ought to be able to just reorder that line, putting
xvid_options at the end. Try the attached patch. If that fixes the
xvidencopts part, you might have to follow my example for some of the
other nearby lines in AcidRip/acidrip.pm.
Yes, it works, thanks.But I think even this way it is not clean: next time, mencoder will refuse also the trailing ":". So I think the best is to test if xvid_options is empty (it is initialised to '' at the beginning) and create 2 different lines depending of the result of the test.
Something like:
if ( $::settings->{'video_codec'} eq 'xvid' ) {
if ($xvid_options) ne '' {
$menc{'video'} = "-ovc xvid -xvidencopts
$::settings->{'xvid_options'}:bitrate=$::settings->{'video_bitrate'}";
} else {
$menc{'video'} = "-ovc xvid -xvidencopts
bitrate=$::settings->{'video_bitrate'}";
}
or:
if ( $::settings->{'video_codec'} eq 'xvid' ) {
$memc{'video'} = "-ovc xvid -xvidencopts ";
$menc{'video'} .= "$::settings->{'xvid_options'}:" if
$xvid_options ne '';
$menc{'video'} .= "bitrate=$::settings->{'video_bitrate'}";
$menc{'video'} .= ":pass=$::settings->{'video_pass'}" if
$::settings->{'video_passes'} > 1;
}
-Corey
Jean-Luc
Attachment:
pgpSoKtR3fO52.pgp
Description: PGP signature