Re: acidrip: doesnt work with latest versions of mencoder

[Corey Hickey <bugfood-ml@fatooh.org>]

Jean-Luc Coulon (f5ibh) wrote:

>>>me) dont dont accept the -xvidencopts suboption which is used by
>>>acidrip, typically with something like:
>>>  ".... -xvidencopts :bitrate=759:pass=2 ..."
>>>
>>
>>Yes, the ':' before bitrate is a syntax error. I don't know if earlier
>>versions of mencoder were tolerant of that.

I don't know perl, but I can see what's going on.

Line 221 of AcidRip/acidrip.pm:

$menc{'video'} = "-ovc xvid -xvidencopts
$::settings->{'xvid_options'}:bitrate=$::settings->{'video
_bitrate'}";

xvid_options is empty, leaving only the ':'. Mencoder accepts a trailing
':', so you ought to be able to just reorder that line, putting
xvid_options at the end. Try the attached patch. If that fixes the
xvidencopts part, you might have to follow my example for some of the
other nearby lines in AcidRip/acidrip.pm.

-Corey

diff -aur acidrip-0.14.orig/AcidRip/acidrip.pm acidrip-0.14/AcidRip/acidrip.pm
--- acidrip-0.14.orig/AcidRip/acidrip.pm	2004-07-25 07:03:09.000000000 -0700
+++ acidrip-0.14/AcidRip/acidrip.pm	2005-10-19 13:37:57.000000000 -0700
@@ -218,7 +218,7 @@
     $menc{'video'} .= ":pass=$::settings->{'video_pass'}" if $::settings->{'video_passes'} > 1;
   }
   if ( $::settings->{'video_codec'} eq 'xvid' ) {
-    $menc{'video'} = "-ovc xvid -xvidencopts $::settings->{'xvid_options'}:bitrate=$::settings->{'video_bitrate'}";
+    $menc{'video'} = "-ovc xvid -xvidencopts bitrate=$::settings->{'video_bitrate'}:$::settings->{'xvid_options'}";
     $menc{'video'} .= ":pass=$::settings->{'video_pass'}" if $::settings->{'video_passes'} > 1;
   }
   if ( $::settings->{'video_codec'} eq 'nuv' ) {