[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: rocm-device-libs/5.7~git20231212.5a852ed-1~exp1 -- AMD specific device-side language runtime libraries



Hi Cory,

On 2024-01-07 02:15, Cordell Bloor wrote:
>
> I just used the default for uscan [1] and changed 0.0 to 5.7.
> 
>     *pretty=*/rule/
>         Set the upstream version string to an arbitrary format as an
>         optional *opts* argument when the /matching-pattern/ is *HEAD*
>         or *heads/*/branch/ for *git* mode. For the exact syntax, see
>         the *get-log* manpage under *tformat*. The default is
>         *pretty=0.0~git%cd.%h*. No *uversionmangle* rules is applicable
>         for this case.

Ah, 0.0~git is a special case, it is typically used when no upstream tag
exists yet. It sorts lower than any reasonable first tag that upstream
could choose in future. Hence the default, I guess.

I think a better example for ~ use is:

  5.7~rc1-1~exp1 < 5.7~rc1-1 < 5.7~rc2-1 < 5.7-1

> It's not easy to correlate the branch with a particular version, since
> the branch seems to diverge from the tagged releases a very long ways
> back and is maintained with cherry-picks, but it appears to include
> everything from ROCm 6.0 and beyond. Based on your reasoning, it should
> be 6.0+git<...>. I will update the package to reflect that.

That sounds good, thanks.

On 2024-01-07 05:30, Cordell Bloor wrote:
> I've updated the version to 6.0+git20231212.5a852ed-1~exp1.

Built, tagged, and uploaded with binaries (for NEW), thanks.

This shouldn't trigger tests in our CI, as nothing yet depends on
bin:rocm-device-libs-17. If it does trigger tests, I'll have a bug to
fix in the resolver.

This isn't urgent, but going forward, do you have an rough idea how an
updated device-libs and hipcc will affect the other packages? Will we
need rebuilds with the newer hipcc? Could there be breakage that we need
to specify in debian/control?

Best,
Christian


Reply to: