[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RFS: rocm-device-libs/6.0+git20231212.5a852ed-1~exp1 (Was: RFS: rocm-device-libs/5.7~git20231212.5a852ed-1~exp1 -- AMD specific device-side language runtime libraries)



Hi Christian,

On 2024-01-06 18:15, Cordell Bloor wrote:

I'll update the copyright date upstream and the question will be moot.

I've forwarded the suggestion upstream [2]. I think we can proceed as-is for now, and it will eventually be resolved through Debian's standard procedures when updating to a new upstream version.

 rocm-device-libs (5.7~git20231212.5a852ed-1~exp1) experimental; urgency=medium
                       ^^^
A ~git suffix is somewhat unusual as ~ sorts before:

  $ dpkg --compare-versions 5.7~git20231212.5a852ed '<<' 5.7; echo $?
  0

With git, usually, it's +git to indicate that this is based on the 5.7
tag, plus some git commits added on top of that, for example to track
bleeding edge.

Was the ~git intentional? I admit to not having checked upstream too
deeply on this, so apologies if this is noise on my end.

(You mention in a commit that we are tracking the release/17.x branch
now because that's the one basing on stable LLVM releases; that part was
clear.)
[...]

It's not easy to correlate the branch with a particular version, since the branch seems to diverge from the tagged releases a very long ways back and is maintained with cherry-picks, but it appears to include everything from ROCm 6.0 and beyond. Based on your reasoning, it should be 6.0+git<...>. I will update the package to reflect that.

I've updated the version to 6.0+git20231212.5a852ed-1~exp1.

Sincerely,
Cory Bloor

[2]: https://github.com/ROCm/ROCm-Device-Libs/pull/104

Reply to: