[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: rccl/5.3.3-2 -- ROCm Communication Collectives Library



On 2023-05-27 07:17, Cordell Bloor wrote:
>> The common pattern seems to be to ship a -tests package:
>>
>>    $ apt-cache search '\-tests$'
>>
>> I was sloppy and shipped rocrand's tests as -test (singular), which I'll
>> have to fix.
> 
> Are you sure that you will be renaming librocrand1-test to
> librocrand1-tests?
> 
> I have prepared librocsparse0-test, which packages the rocsparse-test
> binary, and librocfft0-test, which packages the rocfft-test binary. If
> you're certain that you'll be pluralizing the rocrand package, then I
> suppose I should pluralize the rocsparse and rocfft equivalents.

I do think that -tests is a slightly more accurate description of the
package: it ships tests. When I chose "test", I had the verb in mind,
but the package doesn't really do anything by itself.

TBH, I was 100% sure until I saw that (singular)

  $ apt-cache search '\-test$'

also has quite a few hits. So there is no consensus on this.


One thing is clear, we need a policy for this anyway. That's not the
only design choice I made when I created that first package.

I've drafted a wiki page for discussion and will share it shortly.

Best,
Christian




Reply to: