Re: liblouis misc fixes
On Tue, Aug 18, 2009, Samuel Thibault wrote:
> > > > * Use AC_CONFIG_FILES/AC_OUTPUT to generate python/louis/__init__.py.
> > >
> > > I was tempted to do such kind of thing, but
> > > expr $LIBLOUIS_CURRENT - $LIBLOUIS_AGE
> > > is really not portable, see the libtool script for examples of what
> > > happens on other OSes. Also, you are missing the library suffix which
> > > may also vary, etc. That's really not something we can submit upstream
> > > which does need to support other OSes than linux.
> >
> > Hmm I guess we could use $PYTHON to find out.
>
> ??
>
> I don't see how that can be cleaner than just taking automake's output.
Automake's output? I'm suggesting to use AC_CONFIG_FILES/AC_OUTPUT
which seem more natural here; I think $(shell ) and the extra
constructs are best avoided, but you complain about the use of "expr",
so I simply propose to use python instead which is here if we build the
python bindings, right?
--
Loïc Minier
Reply to: