[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: liblouis misc fixes



Loïc Minier, le Tue 18 Aug 2009 18:35:52 +0200, a écrit :
> On Tue, Aug 18, 2009, Samuel Thibault wrote:
> > >   * Don't override LD_LIBRARY_PATH completely as this breaks fakeroot.
> > Take care of the case when LD_LIBRARY_PATH is empty, that adds the
> > current directory.
> 
>  (I don't think that's an issue when the current directory is the package
>  directory)

You can never know what scripts you call do.

> > >   * Use AC_CONFIG_FILES/AC_OUTPUT to generate python/louis/__init__.py.
> > 
> > I was tempted to do such kind of thing, but
> > expr $LIBLOUIS_CURRENT - $LIBLOUIS_AGE
> > is really not portable, see the libtool script for examples of what
> > happens on other OSes.  Also, you are missing the library suffix which
> > may also vary, etc.  That's really not something we can submit upstream
> > which does need to support other OSes than linux.
> 
>  Hmm I guess we could use $PYTHON to find out.

??

I don't see how that can be cleaner than just taking automake's output.

Samuel


Reply to: