Re: Atari Falcon platform drivers
Hi Michael,
On Thu, Jun 20, 2019 at 5:58 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> Am 19.06.2019 um 20:53 schrieb Geert Uytterhoeven:
> > On Wed, Jun 19, 2019 at 10:30 AM John Paul Adrian Glaubitz
> > <glaubitz@physik.fu-berlin.de> wrote:
> >> On 6/11/19 3:12 AM, Finn Thain wrote:
> >>> I also found that the old installer bug which prevents CD-ROM drive
> >>> detection on Atari is still there. I had to spawn a shell to run these
> >>> commands:
> >>>
> >>> # modprobe pata-falcon
> >>> # modprobe isofs
> >>> # mount /dev/sr0 /cdrom
> >>>
> >>> Then the "Detect and mount CD-ROM" step then worked. (You can use
> >>> falconide and /dev/hdX instead.)
> >>
> >> Yes, this is known and I currently don't know how to fix this. Again, if someone
> >> knows how to make the installer load the modules, please let me know. I assume
> >> the problem is that there is no autodetection here so udev can't load the
> >> modules automatically.
> >
> > drivers/ide/falconide.c and drivers/ata/pata_falcon.c should be converted
> > to proper platform drivers, matching against a platform device registered
> > in arch/m68k/atari/config.c.
>
> And that's going to help with autoloading modules?
Yes, platform drivers have automatic module aliases.
Compare e.g.
$ modinfo drivers/ata/pata_falcon.ko
filename: drivers/ata/pata_falcon.ko
version: 0.1.0
license: GPL v2
description: low-level driver for Atari Falcon PATA
author: Bartlomiej Zolnierkiewicz
srcversion: 84A5F6FDA8A93A0BC6F8B9E
depends: libata
intree: Y
name: pata_falcon
vermagic: 5.2.0-rc5+ mod_unload modversions
$ modinfo drivers/ata/pata_gayle.ko
filename: drivers/ata/pata_gayle.ko
version: 0.1.0
alias: platform:amiga-gayle-ide
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
license: GPL v2
description: low-level driver for Amiga Gayle PATA
author: Bartlomiej Zolnierkiewicz
srcversion: DC5461633EF515ACD5AB512
depends: libata
intree: Y
name: pata_gayle
vermagic: 5.2.0-rc5+ mod_unload modversions
> In this particular instance, both drivers would need to bind to the same
> platform device - how do we handle this case?
That's easy: the first driver bound wins ;-)
> pata_falcon.c is probably easiest to convert, and should be sufficient
> to test with the installer. falconide.c is going away in two years
> anyway, and I can't test these changes on my hardware, so I'd rather
> leave this one alone.
pata_falcon.c alrwady creates its own platform device inside the driver,
so that's indeed the easiest to convert.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Reply to: