[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Amiga 1200 Network Card



Hi,

Am 14.09.2018 um 09:37 schrieb ALeX Kazik:
Hi,

I've created now a configureable version.
It can be only activated when apne is on and all others drivers are off.

I keep the reset patch part of the new feature since I don't have
another apne card I can't test it (even though I'm guessing it would
be useful for all amiga pcmcia cards).

I've moved the hack to the header file and first tests confirm that it
works. Attached are both variants.

What exactly should I do next?

First, make certain that your patch does not violate any of the recommended coding style for the Linux kernel (scripts/checkpatch.pl is your friend there).

Send the second version to netdev@vger.kernel.org, with cc: to linux-m68k@vger.kernel.org, with a subject header containing the tag [PATCH RFC net] and a one-line description such as 'Amiga PCMCIA 100 MBit card support'.

Please add a detailed patch description to explain what this patch does in the body of the mail, before the patch. Don't forget to add your Signed-off-by: tag at the end of the description. See the file Documentation/process/submitting-patches.rst in your kernel source tree for a lot more hints along these lines. Also see Documentation/networking/netdev-FAQ.rst for hints specific to netdev.

You will be submitting to the 'net' tree as this is clearly a bugfix, and there's no need to pay any attention to whether or not net-next is currently accepting patches (it is, at this time).

If you use git for your kernel source tree, the command 'git send-email' can be used to send out the patch, using the commit log message as patch description. But any patch generated using 'diff -up' should be fine.

Someone among the netdev maintainers will review your patch and provide feedback, which you will be well advised to address to the greatest extent possible. The netdev FAQ gives the URL of the netdev patch tracker, which I've found very handy to follow the progress of patches. Once all review comments have been addressed, patches usually make it into the next release without further intervention.

Cheers,

	Michael


ALeX.



Reply to: