Re: [parted-devel] Atari label false positives

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Adrian,

Am 12.05.2018 um 19:59 schrieb John Paul Adrian Glaubitz:
> On 05/12/2018 01:17 AM, Michael Schmitz wrote:
>> The link order in the kernel (atari before msdos) has not been chosen at
>> random. The msdos partition format probe will always succeed on any
>> valid Atari partition table, while Atari format probe should not succeed
>> on plain MSDOS partitions.

I had that the wrong way - link order is not what matters here, the
checks order has msdos before atari in fact.

>>
>> Do the reporters if these bugs have Atari partition format enabled in
>> their kernels? I would expect the same false positives to happen there,
>> if the atari_probe() code is functionally equivalent to the kernel
>> partition probe code.
>> Do you have a dump of the root sector (plus additional eventual extended
>> partition root sector) from these bugs?
> 
> This is a very good point. We should have a look at the probing code in
> the kernel because apparently the problem doesn't exist there.

It may not exist because the MSDOS partition detection is specific
enough to reject Atari partition tables. But still, compare the kernel
partition parsers to see what may be missing.

Cheers,

	Michael

> And, yes, it would be interesting to get a dump of these boot sectors as
> I haven't run into the problem myself and would be very curios why
> the misdetection happens.
> 
> Adrian
>