[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [parted-devel] Atari label false positives

On 05/11/2018 05:56 PM, Phillip Susi wrote:
On 5/11/2018 11:29 AM, John Paul Adrian Glaubitz wrote:
Thanks for digging this up. I wasn't aware of this particular issue before
and I agree, this needs to be addressed. I hope that I didn't cause too
many DOS partitions to be misdetected. Sorry for the inconvenience if I
did. The Atari partition table code has been working great for
Debian/m68k so
far though.

I have seen at least one or two reports of Ubuntu users getting false
positives, and then I saw the bug report on the upstream parted bug
tracker the other day where someone claimed to have found a logical
error that caused atari_probe to return true when it shouldn't.  I
finally realized it was not an error ( at least I think not ).

According to the documentation, p.43 [1], I think offset $01 should always
contain either "GEM", "BGM" or "XGM". They don't seem to be optional.

I guess adding those to atari_probe() should help improve the detection
quite a bit. But I would have to test that first.

I think I will at least move atari to be probed after all other labels
have failed.

This sounds like a reasonable thing to do until I have worked out
a patch to improve atari_probe().


[1] https://people.debian.org/~glaubitz/Atari_HD_File_Sytem_Reference_Guide.pdf

 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply to: