[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#842787: graphicsmagick: Please honor 'nocheck' in DEB_BUILD_OPTIONS

Source: graphicsmagick
Version: 1.3.25-5
Severity: important
User: debian-68k@lists.debian.org
Usertags: m68k


The graphicsmagick source currently does not honor when 'nocheck' is
set in DEB_BUILD_OPTIONS which means that it's not possible to disable
tests from the build environment and these are performed during every

However, since it's sometimes desirable to be able to disable tests
(when debugging the package or when building on a slow machines like
 m68k or sh4 machines) and most Debian source packages actually honor
'nocheck' when set, I would suggest the following simple patch which
modifies debian/rules to allow to disable tests in graphicsmagick
by passing 'nocheck' to DEB_BUILD_OPTIONS:

--- debian/rules.orig   2015-09-25 06:51:44.000000000 +0900
+++ debian/rules        2016-11-01 14:51:48.088859977 +0900
@@ -135,6 +135,7 @@
 check: check-stamp
 check-stamp: build-arch-stamp
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
        # Cannot patch a binary file, so do take a detour via uudecode...
@@ -167,7 +168,7 @@
        else \
                echo "Skipping regression tests because we appear to be cross-compiling"; \
        touch check-stamp


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply to: