[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#842768: ruby2.3: Please honor 'nocheck' flags in DEB_BUILD_OPTIONS

Source: ruby2.3
Version: 2.3.1-5
Severity: important
User: debian-68k@lists.debian.org
Usertags: m68k


The rules file of the ruby2.3 source package is currently written such it
will always run the testsuite, independent whether DEB_BUILD_OPTIONS contains
'nocheck' or not. Normally the 'nocheck' flag is honoured by dh_auto_test*.

However, since the rules file for rub2.3 overrides the dh_auto_test-arch
target, the flag is no longer honored and tests are always executed which
is problematic especially on slower architectures (e.g. m68k). Plus, when
doing test builds, it's always useful to be able to disable the testsuite
to reduce build time.

I would therefore like to ask I suggest the following the patch which makes
the rules file honor 'nocheck' again when it's present in the DEB_BUILD_OPTIONS:

--- debian/rules.orig   2016-11-01 14:31:50.017776596 +0900
+++ debian/rules.new    2016-11-01 14:30:50.697611300 +0900
@@ -69,7 +69,9 @@
        dh_auto_build -- main V=1

+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
        $(MAKE) check V=1

        $(MAKE) install-nodoc V=1 DESTDIR=$(CURDIR)/debian/tmp

This is also how the rules file for the ffmpeg package checks for the
'nocheck' flag in DEB_BUILD_OPTIONS:


 .''`.  John Paul Adrian Glaubitz
 : :' :  Debian Developer - glaubitz@debian.org
 `. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply to: