[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#717689: linux: please review and merge m68k patch



On Tue, Jul 23, 2013 at 08:42:04PM +0000, Thorsten Glaser wrote:
> +CONFIG_IOSCHED_DEADLINE=m
> +CONFIG_IOSCHED_CFQ=m

Should be configured in the top config.

> +# CONFIG_EXT2_FS_SECURITY is not set
> +# CONFIG_EXT3_FS_SECURITY is not set

Why?

> -CONFIG_EXT4_FS=y
> -CONFIG_EXT4_USE_FOR_EXT23=y

You could still stick to this option.

> +CONFIG_NFS_SWAP=y
> +CONFIG_NLS_MAC_ROMAN=m
> +CONFIG_NLS_MAC_CELTIC=m
> +CONFIG_NLS_MAC_CENTEURO=m
> +CONFIG_NLS_MAC_CROATIAN=m
> +CONFIG_NLS_MAC_CYRILLIC=m
> +CONFIG_NLS_MAC_GAELIC=m
> +CONFIG_NLS_MAC_GREEK=m
> +CONFIG_NLS_MAC_ICELAND=m
> +CONFIG_NLS_MAC_INUIT=m
> +CONFIG_NLS_MAC_ROMANIAN=m
> +CONFIG_NLS_MAC_TURKISH=m

Why here?

> +CONFIG_LOG_BUF_SHIFT=16

Why override?

> +## choice: Preemption Model
> +CONFIG_PREEMPT_NONE=y
> +# CONFIG_PREEMPT_VOLUNTARY is not set
> +# CONFIG_PREEMPT is not set
> +## end choice

Isn't this already set?

> +##
> +## file: unknown
> +##

You want to take a look at this options.

Bastian

-- 
I have never understood the female capacity to avoid a direct answer to
any question.
		-- Spock, "This Side of Paradise", stardate 3417.3


Reply to: