Re: Bug#717689: linux: please review and merge m68k patch
Bastian Blank dixit:
>On Tue, Jul 23, 2013 at 08:42:04PM +0000, Thorsten Glaser wrote:
>> +CONFIG_IOSCHED_DEADLINE=m
>> +CONFIG_IOSCHED_CFQ=m
>
>Should be configured in the top config.
They’re =y there. I put them into modules to save space.
>> +# CONFIG_EXT2_FS_SECURITY is not set
>> +# CONFIG_EXT3_FS_SECURITY is not set
>
>Why?
Saving space since CONFIG_SECURITY=n.
>> -CONFIG_EXT4_USE_FOR_EXT23=y
>
>You could still stick to this option.
The debian/config/config doesn’t use it and builds
separate ext2/ext3/ext4 modules instead, so I did
that too.
>> +CONFIG_NFS_SWAP=y
>> +CONFIG_NLS_MAC_ROMAN=m
>> +CONFIG_NLS_MAC_CELTIC=m
>> +CONFIG_NLS_MAC_CENTEURO=m
>> +CONFIG_NLS_MAC_CROATIAN=m
>> +CONFIG_NLS_MAC_CYRILLIC=m
>> +CONFIG_NLS_MAC_GAELIC=m
>> +CONFIG_NLS_MAC_GREEK=m
>> +CONFIG_NLS_MAC_ICELAND=m
>> +CONFIG_NLS_MAC_INUIT=m
>> +CONFIG_NLS_MAC_ROMANIAN=m
>> +CONFIG_NLS_MAC_TURKISH=m
>
>Why here?
Because debian/config/config didn’t contain them.
But they could be moved there, yes – but I didn’t
want to touch !m68k space.
>> +CONFIG_LOG_BUF_SHIFT=16
>
>Why override?
Saving some more space… I will retract this line
if you say so.
>> +## choice: Preemption Model
>> +CONFIG_PREEMPT_NONE=y
>> +# CONFIG_PREEMPT_VOLUNTARY is not set
>> +# CONFIG_PREEMPT is not set
>> +## end choice
>
>Isn't this already set?
No, it’s set to CONFIG_PREEMPT_VOLUNTARY.
>> +##
>> +## file: unknown
>> +##
>
>You want to take a look at this options.
Right… I did have that planned but forgot.
I looked at them all, and the entire block can go,
they don’t appear in this century’s kernel source ;-)
bye,
//mirabilos
--
17:08⎜«Vutral» früher gabs keine packenden smartphones und so
17:08⎜«Vutral» heute gibts frauen die sind facebooksüchtig
17:10⎜«Vutral» aber auch traurig; früher warst du als nerd voll am arsch
17:10⎜«Vutral» heute bist du als nerd der einzige der wirklich damit klarkommt
Reply to: