Re: [PATCH] Atari ROM port (cartridge port) ISA adapter access

[Michael Schmitz <schmitz@mail.biophys.uni-duesseldorf.de>]

> > +#define rom_in_8(addr) \
> > +    ({ u8 __v = (*(__force volatile u8 *) (addr)); __v >>= 8; __v; })
>
> This will always return zero.

Thanks. The address translation part had an error as well (shifting up by
9 and then masking off everything but the lowest 5 bits always gives
zero). When Kars warned me to be careful of 16 vs. 8 bit access I thought
about using 16 bit there but forgot to implement it.

Would

	({ u16 __v = (*(__force volatile u16 *) (addr)); __v >>= 8; __v; })

work as expected, or do I have to cast the 'return' value?

	Michael