On Thu, 2007-02-15 at 05:26 +0100, Julien Cristau wrote:
>
> +SERVERABI = $(shell cat /usr/share/xserver-xorg/serverabiver || true)
> +SERVER_DEPENDS = xserver-xorg-core (>= $(SERVERABI))
What's the || true for? Looks like SERVER_DEPENDS relies on the file
being there anyway.
> This means that drivers need to set the PACKAGE variable in
> debian/rules
> before including xsfbs.mk,
Maybe the package name could be derived from the build directory name if
this isn't set explicitly? Not a big deal I guess.
> add a dependency from their "binary-arch"
> target on "serverabi", and replace the hardcoded xserver-xorg-core
> dependency in their control files with ${xserver:Depends}. What do
> you
> think?
Looks good to me otherwise.
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer