[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

handling of minor driver ABI bumps



On Mon, Feb 12, 2007 at 08:15:15 +0100, Michel Dänzer wrote:

> Minor ABI bumps are backwards compatible, so they merely require the
> drivers to depend on xorg-server-core (>= <upstream version built
> against>).
> 
> xserver-xorg-video-1.0 was introduced for a major bump from 0.x to 1.0,
> which was backwards incompatible.
> 
OK, so this is my first try at a patch for xsfbs to generate these
dependencies:

From 2140da8d3a5ff0543846b0ffc8aff76a9336ee54 Mon Sep 17 00:00:00 2001
From: Julien Cristau <jcristau@debian.org>
Date: Thu, 15 Feb 2007 05:11:57 +0100
Subject: [PATCH] Add new rule to generate a dependency from drivers on xserver-xorg-core.

---
 debian/xsfbs/xsfbs.mk |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/debian/xsfbs/xsfbs.mk b/debian/xsfbs/xsfbs.mk
index 7b8206e..03bc074 100755
--- a/debian/xsfbs/xsfbs.mk
+++ b/debian/xsfbs/xsfbs.mk
@@ -354,6 +354,18 @@ $(STAMP_DIR)/genscripts: $(STAMP_DIR)/stampdir
 debian/shlibs.local:
 	cat debian/*.shlibs >$@
 
+SERVERABI = $(shell cat /usr/share/xserver-xorg/serverabiver || true)
+SERVER_DEPENDS = xserver-xorg-core (>= $(SERVERABI))
+
+.PHONY: serverabi
+serverabi:
+ifeq ($(PACKAGE),)
+	@echo please define the PACKAGE variable
+	exit 1
+else
+	echo "xserver:Depends=$(SERVER_DEPENDS)" >> debian/$(PACKAGE).substvars
+endif
+
 include debian/xsfbs/xsfbs-autoreconf.mk
 
 # vim:set noet ai sts=8 sw=8 tw=0:
-- 
1.4.4.4

This means that drivers need to set the PACKAGE variable in debian/rules
before including xsfbs.mk, add a dependency from their "binary-arch"
target on "serverabi", and replace the hardcoded xserver-xorg-core
dependency in their control files with ${xserver:Depends}.  What do you
think?

Cheers,
Julien

Attachment: pgp42URPlIA3s.pgp
Description: PGP signature


Reply to: