Re: RFS: policyd-weight (3rd)

[werner@aloah-from-hell.de]

Hi again,

I do have another question left.

I've just discovered that there are some files left in the debian directory after package
creation, e.g.

debian/files
debian/policyd-weight.*
debian/policyd-weight.*.debhelper
debian/*.dephelper.log
debian/policyd-weight/

As source packages should not contain files like "debian/files". I've enabled Debugging via
DH_VERBOSE=1 and I do see that dh_clean is deleting those files pretty much at the beginning
of package-creation.

-- cut --
debian/rules clean
dh_testdir
dh_testroot
dh_clean
        rm -f debian/policyd-weight.substvars
        rm -f debian/policyd-weight.*.debhelper
        rm -rf debian/policyd-weight/
        rm -f debian/*.debhelper.log
        rm -f debian/files
        find .  \( \( -type f -a \
                \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
                 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
                 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
                 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
                \) -exec rm -f {} \; \) -o \
                \( -type d -a -name autom4te.cache -prune -exec rm -rf {} \; \) \)
        rm -f *-stamp
-- cut --

So as those files are just deleted at the beginning of the package and afterwards are recreated
through the build process. I'm not sure if

a) it's ok that the files reside in the debian directory ?
b) I missed a "dh_clean" (or pedant) somewhere ?
c) I have to delete those manually?

Thank you,
Werner Detter

PS: here's my debian/rules snippet
clean:
	dh_testdir
	dh_testroot
	dh_clean

install: build
	dh_testdir
	dh_testroot
	dh_prep
	dh_installdirs

	install -D -m 644 policyd-weight debian/policyd-weight/usr/sbin/policyd-weight

# Build architecture-independent files here.
binary-indep: build install
	dh_testdir
	dh_testroot
	dh_installchangelogs changes.txt
	dh_installdocs
	dh_installinit -- defaults 19 21
	dh_installman man/man5/policyd-weight.conf.5 man/man8/policyd-weight.8
	dh_link
	dh_compress
	dh_fixperms
	dh_perl
	dh_installdeb
	dh_gencontrol
	dh_md5sums
	dh_builddeb

# Build architecture-dependent files here.
build-arch: build
build-indep: build
binary-arch: build install

binary: binary-indep binary-arch
.PHONY: build clean binary-indep binary-arch binary install