Re: RFS: policyd-weight (3rd)

[werner@aloah-from-hell.de]

Hi Thomas,

thanks for your helpfull comments.

> What was in /etc/default/policyd-weight? Why aren't you using
> it anymore?

It behaves like the current package in unstable/testing/stable.
The file /etc/default/policyd-weight isn't created but the init
script takes account of it.

/etc/default/policyd-weight is the place to add daemon-options for
policyd-weight.

What should we do here? Generate the file? Or don't take account of
it in the init script?

> Your package seems using /var/run/policyd-weight/, but where
> exactly is that folder created? Shouldn't an mkdir -p be added
> to your init.d script? What is the use of /var/run/policyd-weight
> by the way?

The creation of this directory is done by policyd-weight, so no need
to create it via the init-script. Policyd-weight uses this directory
for saving the PID and furthermore creates some more directories in
/var/run/policyd-weight (for caching etc.). It behaves like the current
policyd-weight in unstable/testing/stable.

Thank you and best regards,
Werner Detter






















> 
> Apart from that, I think the package is nicely improved, and
> would deserve to be uploaded.
> 
> Thomas
>